port details for APIServerURL #646
Conversation
|
Hi @garbagego. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
config/v1/types_infrastructure.go
Outdated
|
|
||
| // apiServerURL is a valid URI with scheme(http/https), address and | ||
| // port. apiServerURL can be used by components like the web console | ||
| // port(only if not using default port HTTP 80 and HTTP/TLS 443). apiServerURL can be used by components like the web console |
There was a problem hiding this comment.
How about ... and optionally a port (defaulting to 80 for http and 443 for https)?
You also have to generate the CRDs. make update or something like that. make help shows you the commands.
There was a problem hiding this comment.
@sttts Thanks for your suggestion.
I have updated the api doc and updated CRD by calling make update-codegen-crds
| apiServerURL: | ||
| description: apiServerURL is a valid URI with scheme(http/https), address | ||
| and port. apiServerURL can be used by components like the web console | ||
| and port and optionally a port (defaulting to 80 for http and 443 |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Need a swagger doc update. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garbagego, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…L too We've declared the default ports for apiServerURL since afb690a (modified port details for APIServerURL, 2020-05-13, openshift#646). Echo that for apiServerInternalURL. We don't have to call this out explicitly, since the IANA URI scheme registry [1] links out to [2] for http and [3] for https, which have: If the port subcomponent is empty or not given, TCP port 80 (the reserved port for WWW services) is the default. and: All of the requirements listed above for the "http" scheme are also requirements for the "https" scheme, except that TCP port 443 is the default if the port subcomponent is empty or not given... respectively. But echoing those defaults locally doesn't hurt. Autogenerated bumps via: $ hack/update-swagger-docs.sh $ make update-codegen-crds [1]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml [2]: https://tools.ietf.org/html/rfc7230#section-2.7.1 [3]: https://tools.ietf.org/html/rfc7230#section-2.7.2
5 participants
#openshift/cluster-kube-apiserver-operator#855